This repository was archived by the owner on Aug 1, 2025. It is now read-only.
fix: resolve issue with artifacts naming - #8195
Merged
Merged
Conversation
cloudyadi
approved these changes
Jul 23, 2025
0xnmn
approved these changes
Jul 23, 2025
0xnmn
pushed a commit
that referenced
this pull request
Jul 24, 2025
When a failure occurs in the e2e tests, we upload some of the artifacts for access. However, the naming of this artifact isn't unique and when an artifact with the same name exists, it throws an error. This PR makes the artifact name unique and overwrites it in the event that running the workflow multiple times returns an error ## Test plan * CI <br> Backport f4280dc from #8195 Co-authored-by: Bolaji Olajide <25608335+BolajiOlajide@users.noreply.github.com> Co-authored-by: David Ichim <ichim.david@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a failure occurs in the e2e tests, we upload some of the artifacts for access. However, the naming of this artifact isn't unique and when an artifact with the same name exists, it throws an error.
This PR makes the artifact name unique and overwrites it in the event that running the workflow multiple times returns an error
Test plan